Drupal CMS

You are welcome, enjoy the module!

Fons added a comment on drupal.org: Fix the issues reported by phpcs

Fons added a comment on drupal.org: Addition to readme for composer

The README file and the Project detail page have been updated to support installation via Composer.

Randal added a comment on drupal.org: TypeError_: unserialize(): Argument #1 ($data) must be of type string, array given in _unserialize()

That's a very interesting development... an array containing the serialized content with `50` as its key, thanks for sharing @mahde! I'll debug some more too and see if I can reproduce it somehow. I also notice it adds both roles twice, interesting!

Hi @mahde,

Thanks for taking the time to debug and updating the MR! This brings us back to my comment in #5 though, there's only one piece of code in the module that updates the user data for roles, and it always serializes it.. I don't understand how it could possibly contain an array unless some other module messes with it 😓

I'm sorry guys, I've tried debugging this but nothing seems to point to an error 😓

Could you perhaps provide me with a list of contrib modules currently in use? That way I could test with those, maybe one of them triggers something malicious in msqrole.

PS. I did fix some little bits here and there in the latest release, in the D11 compatible version there were some regressions, but none of which should have caused the main issue raised here. The "access denied" error you mentioned, @mahde, should be fixed though.

Fons added a comment on drupal.org: Addition to readme for composer

Dear Duckydan

Thank you for this suggestion, this would indeed improve the developer experience.

I'll test this and add it the Readme after my vacation.

Thank for your patience

Fons

Hi @mahde,

If you could also please provide more information on how to reproduce this bug, we could move forward with this. Currently on a fresh install of D10/11, nothing of the sort seems to happen..

Thank you!

Fons added a comment on drupal.org: Automated Drupal 11 compatibility fixes for readremaining

Fons added a comment on drupal.org: Automated Drupal 10 compatibility fixes

Fons added a comment on drupal.org: Automated Drupal 11 compatibility fixes for taggd

Fons added a comment on drupal.org: Automated Drupal 10 compatibility fixes

A configure link was added in the D11 release.

Fons added a comment on drupal.org: Spacing not working

Thank you, i'll review this patch.

I just released a Drupal 11 update.

Hi markconroy,

Thanks for reporting a possible bug. Could you provide a little more information on how to reproduce this error? I don't seem to get this on a clean install. Any contrib modules that might interfere?

From what I can tell, the unserialize function in the below piece of code should only be run if the data isn't empty.

    if (!empty($this->getData($uid, 'roles'))) {
      $data = unserialize($this->getData($uid, 'roles'));
    }

However, it should be impossible for this data to be anything but a string, since it's only set by one function (the below code) and that code serializes the value before committing it to the DB.

  public function setRoles($uid, array $roles) {
    return $this->setData($uid, 'roles', serialize($roles));
  }

Hence why it sounds like some external source might be messing with the msqrole user data 🤔

PS. While the MR seems just fine, it simply shouldn't be needed.. Hence why I currently see that check more as unnecessary clutter, so I'd prefer to be able to reproduce it and perhaps fix it in a different way 😇

Just scanned the code of the module real quick and indeed this module would need a good portion of rewrites in order to work with Layout Builder.

Fons added a comment on drupal.org: Content overlaps

Glad it worked!

Good luck with the project

Kind request for the current maintainer of this module to grant this person co-maintainership. I see there's no longer any supported version, while this is definitely a useful feature.

Thanks in advance!

Fons added a comment on drupal.org: Content overlaps

@ozin MR updated according to the last patch provided by @Dylan Donkersgoed.

RandalV made their first commit to this issue’s fork.

Hi @remoschneider,

Please, refrain from posting a patch that isn't functionally brought up to date. The patch you posted applies, but is buggy due to the lack of the 'getPluginBlockId'-method in the InlineBlockEntityOperations class.

I'll post a patch that is functionally in line with the old one, if someone wants to turn it into an MR.

@alexpott

• MR applies cleanly to 10.3.x
• Done some tests and the results are as expected:
  • Same hash salt -> same session cookie name
  • Different hash salt -> different session cookie name
  • Can stay logged in across all subsites of a multisite on the same hostname with different hash salt
  • Giving all subsites the same hash salt has the expected behavior of being logged out when visiting a different subsite

Seems ready to me! Thanks for the MR.

This module provides an email message field (consisting of an email subject and email body). While this could also be achieved by a regular textfield + textarea field, there are occasions where you want to reference an email message as a whole. This module provides that ability.

Features

• Drupal field for adding an email subject / body.
• SOON: Submodule: optional integration with Site Settings and Labels module, to allow easy integration of configurable email messages into Drupal mails - via hook_mail() or Symfony Mailer.

Recommended modules/libraries

SOON:

• Site Settings and Labels
• Drupal Symfony Mailer