Drupal CMS

Problem/Motivation

When enabling the setting `show_groups_in_menu`, in combination with admin_toolbar, the `Admin > Content > Site Settings` link gets children for each configured site settings group.

When using the Navigation menu instead, a user needs to select "Content" in the navigation, and then use the "Site settings" tab on that page.

We would like to more easily reach the site settings, including group child links, if enabled.

Moreover, when the `show_groups_in_menu` setting is enabled, the group menu items are added randomly in the main navigation tree (between "Structure", "Appearance", etc.. links), which looks clunky.

Steps to reproduce

- Install navigation core module - No site settings are available.

Proposed resolution

The Navigation module provides a "Content" menu, where it places the default content links ("Create", "Content", "Media", ... When this menu exists, add the "Site settings" + optional group children to it.

Remaining tasks

Create MR

User interface changes

Before:

After

svendecabooter created an issue. See original summary.

Problem/Motivation

Alter logic does not seem to work anymore in Drupal 11.1, since hooks are now OOP.

Steps to reproduce

- Install Drupal 11.1 (I used 11.1.2) - Go to `/admin/config/user-interface/navigation-block` - Click "Add block" in sidebar - Error is triggered, because `navigation_plugin_filter_block__layout_builder_alter()` no longer exists.

Proposed resolution

Call `\Drupal\navigation\Hook\NavigationHooks::pluginFilterLayoutLayoutBuilderAlter()` for newer Drupal versions

Remaining tasks

- Update code with backwards compatibility layer

svendecabooter created an issue. See original summary.

Merged latest changes from 9.0.x into MR branch, seems to apply and work fine on my end. Setting back to 'Needs review' so someone else can have a test before it's merged!

Sven Decabooter added a comment on drupal.org: Invalid entity.site_setting_group.settings route

Problem/Motivation

site_settings.routing.yml contains a route `entity.site_setting_group.settings`, with path `admin/structure/site-setting-group` which triggers a fatal error when called in the browser. I suppose this is a leftover route that is no longer in use?

Steps to reproduce

Go to `admin/structure/site-setting-group` and see error.

Proposed resolution

Remove the route, if it's no longer in use.

svendecabooter created an issue. See original summary.

@scott_euser: ah thanks for the link to the core issue. It would indeed be better if this could be fixed in core itself.

I didn't notice your reply until I started working on an MR.

But I guess the grouping of multiple Site Settings routes under /admin/structure/site-settings could also be useful for sites that do not use Navigation module, as per my screenshots above? Or is that not desired?

Output for Admin > Structure page:

Output for Admin > Structure > Site settings page:

Output with Admin Toolbar contrib module:

Output with core Navigation module:

randalv made their first commit to this issue’s fork.

Randal added a comment on drupal.org: Some twig functions aren't aware of the currently active language

Sven Decabooter added a comment on drupal.org: Improve admin menu links configuration - for navigation module

Problem/Motivation

When using the core Navigation module, the menu item "Manage site settings" is not reachable. Because it has a child menu item, it is considered a grouping menu item, and is not clickable. To reach it, you would need to click the "Manage Site Settings Group" link first, then through the breadcrumb go to its parent.

See screenshot:

Steps to reproduce

Install core Navigation menu, and try to go to "Manage site settings"

Proposed resolution

Use a generic grouping parent item that uses `'\Drupal\system\Controller\SystemController::systemAdminMenuBlockPage'` and add 2 child items under it, one for managing site setting entities, and the other for managing site setting entity groups. Both will then be reachable via the Navigation module.

Remaining tasks

Create a MR

User interface changes

The "Structure > Manage site settings" breadcrumb will become "Structure > Manage site settings > Site settings" or similar.

API changes

/

Data model changes

/

svendecabooter created an issue. See original summary.

Added a WIP MR to fix the issues I already encountered. I will need to dig a bit deeper to see what else is breaking for my project, when I find some more time.

Problem/Motivation

I have an entity type that uses form modes, and is translatable. In version 3.0.0 I was able to translate these entities, by loading them in the appropriate language, and clicking the right form mode manager tab.

E.g. when my original entity has a form mode "Advice", I could go to `/en/{entity_type}/123/edit/advice` and configure the original entity. When I want to set up a translation in Dutch, I'd go to `/nl/{entity_type}/123/edit/advice` and edit the translation of that entity.

In version 3.1.0 that no longer seems to work.

Upon inspecting the changes between 3.0.0 and 3.1.0, I saw a commit related to content translation, which seems to break this functionality. Upon inspection of the code, I noticed the following:

- It seems node-specific in some parts of the code, so wouldn't work with my custom entity - It only adds a "content translation add" route, not an edit route. I'm not sure if that is by design, because the edit path should keep working as I mentioned above (it doesn't for me at least), or if that's been forgotten.

svendecabooter created an issue.

Merge request added!

I also took the liberty to remove what I assume was an orphaned `var_dump` 😇

A little correction from my end, all the functions that call the "renderSiteSettings"-method in the extension class do seem to render with the correct language context, but the other two functions (`site_setting_field` && `site_setting_entity_by_name`) specifically check for a langcode and load that translation, so those should be altered I think.

I'll add a MR for it.

Hi,

First of all thanks for a great module, it works like a charm. I do have a small feature request, it would be nice if the twig function 'site_setting_field(..)' was aware of the current language by default if no language code was provided.

Problem/Motivation

Some twig functions aren't aware of the current language right now. Currently I have to inject the langcode to use it as follows: {{ site_setting_field('[id]', '[field]', '[view_mode]', langcode) }} Instead of ideally just: {{ site_setting_field('[id]', '[field]') }}

That's because Drupal\site_settings\Twig\TwigExtension::singleSiteSettingsByNameAndField does the following:

if ($langcode && $site_setting->hasTranslation($langcode)) {
  $site_setting = $site_setting->getTranslation($langcode);
}

Proposed resolution

Let's make it so that if no langcode was provided, the current language id is given. I suppose the above code snippet would have to become:

$langcode = $langcode ?? $this->languageManager->getCurrentLanguage()->getId();
if ($site_setting->hasTranslation($langcode)) {
  $site_setting = $site_setting->getTranslation($langcode);
}

(The language manager will need to be injected in the class still)

randalv created an issue. See original summary.

Somebody, anybody?

Awesome, thanks!

Thanks, I can look into my own implementation of the navbar then, to better suit my needs. Will have a look at the 5.0.x branch as well - thanks for the heads up

Thanks for the fixes! Can this be rolled into a new release soon, since it's not very user friendly to get fatal errors when trying to configure the module :)

I'm testing out the possibilities of this theme currently. I'm wondering if there is support by default for a responsive menu, because I can't seem to get it working.

I've placed a regular Menu block in the navbar_center region, as well as a "Menu" block provided by UI Patterns module.

From config alone I can't seem to get a responsive menu working, so I might have to strip out and replace some things in the template - but I'm checking first if I'm not missing something obvious.

It looks like the whole navbar component doesn't seem to be very responsive as a whole. I've placed a logo in navbar start, menu in navbar center and language switcher in navbar end, but in mobile view I only see part of the main menu..

Thanks for all your hard work in integrating Daisy UI with UI Suite!

svendecabooter created an issue. See original summary.

Drupal 7 support for this module has been dropped.

Drupal 7 support for this module has been dropped.