Drupal CMS

I'll reopen this since the fix hasn't actually been released yet, nearly 2 years later.

@Maintainer, could you please release a new tagged version with this fix present? Thanks!

Problem/Motivation

Hello, i'm currently using this awesome module and it's really nice. Thank you!

The only feature that I miss / can't find is how to add marker popup data (preferably text) when using the form formatter (Leaflet Map Default).

Now I can add markers (without data / pop-up info), polygons, lines, etc.

How can this be achieved, can anyone put me in the right direction?

Thanks in advance!

I can confirm the MR applies to 1.25.

I now get the aria-label="Cookie privacy banner" parameter in the popup's HTML tag.

(PS. Let's keep working in the MR -if anything needs to change- rather than attaching patches)

Please, feel free to review.

This fixes the issue of terms always being rendered in their default language, rather than the current language.

Problem/Motivation

As a result of #2615864, this module also suffers from issues with translations. It always retrieves taxonomy terms in their default language, rather than the current language.

Steps to reproduce

Create translations of the dictionary vocabulary terms, and add the words to a page in a different language than the default language of the terms.

Proposed resolution

Slightly rework the functionality regarding the loading of taxonomy terms in the TooltipManager class.

I will create a MR with my proposal.

randalv created an issue. See original summary.

Problem/Motivation

It would be nice if we could add the steps to add the Tocbot library that is used by this module with composer.

Proposed resolution

Update the Readme file and project detail page on drupal.org

Remaining tasks

Create a patch, if you are open to this suggestion I don't mind creating and posting the patch. -> Patch in comments

As I see it now the following steps are needed:

INSTALLATION VIA COMPOSER

1. It is assumed you are installing Drupal with Composer (https://www.drupal.org/download).

2. Add the following entry in the "repositories" section of your main composer.json file.

{
            "type": "package",
            "package": {
                "name": "tscanlin/tocbot",
                "version": "4.30.0",
                "type": "drupal-library",
                "source": {
                    "url": "https://github.com/tscanlin/tocbot",
                    "type": "git",
                    "reference": "v4.30.0"
                }
            }
        }

Now you can run the following command to install chosen in the right folder:

composer require tscanlin/tocbot

3. Clear the cache 4. Go to Administration > Configuration > Content Authoring > Tocbot Settings (/admin/config/content/tocbot) 5. Configure the module to your needs 6. Click "Save configuration"

Problem/Motivation

I'm using blazy on a page in different layout blocks.

I've noticed the blazy field gets injected with the same classes for all media fields which to me makes no sense.

Steps to reproduce

Create a page with multiple blazy elements, you'll notice the same group of classes is used on all elements instead of the relevant classes per item.

Proposed resolution

Don't make a huge group of classes and render them on all elements but instead only show the relevant classes per item.

The classes are added in an array in the following file:

blazy/src/Attributes.php

in the following function:

/**
   * Returns the classes applicable only to the first, not nested containers.
   */
  private static function firstClasses(array &$attributes, $blazies, array $options): array {

If you print the classes before the return you'll see the same array that is printed for every item.

Remaining tasks

Needs review

Thanks for the patch/MR. I've applied the MR diff to one of our sites, and the issue has been resolved.

Hopefully this finds its way into a release 🙏

Problem/Motivation

The header of Claro is always rendered even when the regions (page.breadcrumb & page.header) are have no content in it.

Because of this the background and the background color of the header is always rendered which is odd.

Steps to reproduce

Assign no content to the breadcrumb and header regions in Claro, you'll see the background is show on screen.

Proposed resolution

Add a check to see if one of the regions (breadcrumb or header) is filled, if not don't render the header at all.

Problem/Motivation

I disabled some layouts using this module which works fine.

When hiding the navigation_layout an error is thrown:

The website encountered an unexpected error. Try again later.

Drupal\Component\Plugin\Exception\PluginNotFoundException: The "navigation_layout" plugin does not exist. Valid plugin IDs for Drupal\Core\Layout\LayoutPluginManager are: layout_onecol, layout_twocol_bricks, layout_threecol_25_50_25, layout_threecol_33_34_33, layout_builder_blank in Drupal\Core\Plugin\DefaultPluginManager->doGetDefinition() (line 53 of core/lib/Drupal/Component/Plugin/Discovery/DiscoveryTrait.php).

Seems like the navigation_layout does not exist but I do see it when using layout builder (see screenshots in attachment).

Steps to reproduce

Disable the navigation_layout

Randal added a comment on drupal.org: TypeError_: unserialize(): Argument #1 ($data) must be of type string, array given in _unserialize()

That's a very interesting development... an array containing the serialized content with `50` as its key, thanks for sharing @mahde! I'll debug some more too and see if I can reproduce it somehow. I also notice it adds both roles twice, interesting!

Hi @mahde,

Thanks for taking the time to debug and updating the MR! This brings us back to my comment in #5 though, there's only one piece of code in the module that updates the user data for roles, and it always serializes it.. I don't understand how it could possibly contain an array unless some other module messes with it 😓

I'm sorry guys, I've tried debugging this but nothing seems to point to an error 😓

Could you perhaps provide me with a list of contrib modules currently in use? That way I could test with those, maybe one of them triggers something malicious in msqrole.

PS. I did fix some little bits here and there in the latest release, in the D11 compatible version there were some regressions, but none of which should have caused the main issue raised here. The "access denied" error you mentioned, @mahde, should be fixed though.

Hi @mahde,

If you could also please provide more information on how to reproduce this bug, we could move forward with this. Currently on a fresh install of D10/11, nothing of the sort seems to happen..

Thank you!

Hi markconroy,

Thanks for reporting a possible bug. Could you provide a little more information on how to reproduce this error? I don't seem to get this on a clean install. Any contrib modules that might interfere?

From what I can tell, the unserialize function in the below piece of code should only be run if the data isn't empty.

    if (!empty($this->getData($uid, 'roles'))) {
      $data = unserialize($this->getData($uid, 'roles'));
    }

However, it should be impossible for this data to be anything but a string, since it's only set by one function (the below code) and that code serializes the value before committing it to the DB.

  public function setRoles($uid, array $roles) {
    return $this->setData($uid, 'roles', serialize($roles));
  }

Hence why it sounds like some external source might be messing with the msqrole user data 🤔

PS. While the MR seems just fine, it simply shouldn't be needed.. Hence why I currently see that check more as unnecessary clutter, so I'd prefer to be able to reproduce it and perhaps fix it in a different way 😇

Kind request for the current maintainer of this module to grant this person co-maintainership. I see there's no longer any supported version, while this is definitely a useful feature.

Thanks in advance!

@ozin MR updated according to the last patch provided by @Dylan Donkersgoed.

RandalV made their first commit to this issue’s fork.

Hi @remoschneider,

Please, refrain from posting a patch that isn't functionally brought up to date. The patch you posted applies, but is buggy due to the lack of the 'getPluginBlockId'-method in the InlineBlockEntityOperations class.

I'll post a patch that is functionally in line with the old one, if someone wants to turn it into an MR.

@alexpott

• MR applies cleanly to 10.3.x
• Done some tests and the results are as expected:
  • Same hash salt -> same session cookie name
  • Different hash salt -> different session cookie name
  • Can stay logged in across all subsites of a multisite on the same hostname with different hash salt
  • Giving all subsites the same hash salt has the expected behavior of being logged out when visiting a different subsite

Seems ready to me! Thanks for the MR.

This module provides an email message field (consisting of an email subject and email body). While this could also be achieved by a regular textfield + textarea field, there are occasions where you want to reference an email message as a whole. This module provides that ability.

Features

• Drupal field for adding an email subject / body.
• SOON: Submodule: optional integration with Site Settings and Labels module, to allow easy integration of configurable email messages into Drupal mails - via hook_mail() or Symfony Mailer.

Recommended modules/libraries

SOON:

• Site Settings and Labels
• Drupal Symfony Mailer

Rerolled #41 against 10.3.x

Hi @google01,

Merge request definitely applies to 10.3.x.

The contents of this: https://git.drupalcode.org/project/drupal/-/merge_requests/5373.diff Should be downloaded and placed in a local folder (e.g. YOUR_PROJECT/patches/core/3091336.patch), make sure there's an empty line at the end, and then add `patches/core/3091336.patch` in your composer patches list.

Could a maintainer please take a look at this issue? It doesn't change the module's initial installation state, and it adds a lot of possible functionality.

I think this could really spearhead this module's already superb usefulness. (And I'd also be sad to see the work I put in it be for naught :))

Is there any progress on this, or any way to circumvent this and move forward? Recipes are included in 10.3.x, I feel like the priority of solving this should be a little higher now.

I can't seem to get it fixed myself, other than patching core and removing the functionality entirely, but that seems a little nuclear...

On the other hand, I personally do think that this copy functionality should be removed. It definitely doesn't make much sense to copy blocks from one theme to another, given that regions could be entirely different.

Thank you for your patch, alecsmrekar, it seems to work.

I am however unclear on why this issue pops up at all. why is the `layout_builder.move_block_form`-route being triggered when the arguments clearly call for the `layout_builder.move_block` route.

I'm wondering if changing the path for one of the two routes would be a more stable solution? Two routes with very similar paths and arguments, that seems like asking for trouble to me.

Perhaps all non-publicly accessible routes (like ajax routes) should get some prefix, for example.

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes